Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offsets to probe sampler with new unit test #1277

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 8, 2024

Summary

Similar to the PlaneSampler, this PR adds the offset capability to the ProbeSampler. Offsets are added to the entire cloud of points within a given file.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

requested to go with terrain capability, e.g. terrain-aligned sampling

@hgopalan
Copy link
Contributor

hgopalan commented Oct 8, 2024

Thank you for adding this capability. Will help us generate terrain following slices.

@mbkuhn mbkuhn enabled auto-merge (squash) October 8, 2024 20:00
@mbkuhn mbkuhn disabled auto-merge October 8, 2024 20:17
@mbkuhn mbkuhn enabled auto-merge (squash) October 8, 2024 20:31
@mbkuhn mbkuhn merged commit 3ad9250 into Exawind:main Oct 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants