Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up prepare_boundaries as a step prior to ApplyPredictor #1274

Merged
merged 18 commits into from
Oct 21, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 7, 2024

Summary

In order to accommodate the boundary plane implementation and correctly fill physical boundary cells at the right times, this PR sets up a framework to call "fill_boundaries" prior to the ApplyPredictor step, which enables avoiding calling fills at older times (n, n+1/2) once the time step has begun. With all of this new code, this PR is set up to avoid diffs, ensuring the framework does not do something unintentionally. Future PR will introduce diffs by filling BCs at the desired times, instead of conforming to the times the code currently uses.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

The "no diffs" component of development intended by #1210.

The commit to main has the wrong name of the function. Should be "prepare_boundaries" instead of "fill_boundaries"

@mbkuhn mbkuhn requested a review from marchdf October 7, 2024 17:55
@marchdf marchdf self-requested a review October 15, 2024 18:56
@marchdf
Copy link
Contributor

marchdf commented Oct 15, 2024

I am seeing this:

The following tests FAILED:
          7 - abl_godunov_mpl (Failed)
          8 - abl_godunov_mpl_amr (Failed)
         87 - rankine (Failed)
         88 - rankine-sym (Failed)
         92 - freestream_godunov_inout (Failed)
        123 - abl_bndry_input_amr_native_xhi (Failed)
        124 - abl_bndry_input_amr_native_mlbc (Failed)
        128 - abl_bndry_input_amr_inflow (Failed)

I think we might expect the MPL ones? What about the others?

@marchdf
Copy link
Contributor

marchdf commented Oct 16, 2024

Ok now seeing this:

The following tests FAILED:
          7 - abl_godunov_mpl (Failed)
          8 - abl_godunov_mpl_amr (Failed)
        123 - abl_bndry_input_amr_native_xhi (Failed)
        124 - abl_bndry_input_amr_native_mlbc (Failed)
        128 - abl_bndry_input_amr_inflow (Failed)

@marchdf
Copy link
Contributor

marchdf commented Oct 21, 2024

We are at:

The following tests FAILED:
          7 - abl_godunov_mpl (Failed)
          8 - abl_godunov_mpl_amr (Failed)

which is good news. Let's do this.

@mbkuhn mbkuhn marked this pull request as ready for review October 21, 2024 16:57
@mbkuhn mbkuhn merged commit 935b17e into Exawind:main Oct 21, 2024
15 checks passed
@mbkuhn mbkuhn changed the title Set up fill_boundaries as a step prior to ApplyPredictor Set up prepare_boundaries as a step prior to ApplyPredictor Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants