-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up prepare_boundaries as a step prior to ApplyPredictor #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
reviewed
Oct 8, 2024
Co-authored-by: Marc T. Henry de Frahan <[email protected]>
I am seeing this:
I think we might expect the MPL ones? What about the others? |
13 tasks
Ok now seeing this:
|
We are at:
which is good news. Let's do this. |
marchdf
approved these changes
Oct 21, 2024
mbkuhn
changed the title
Set up fill_boundaries as a step prior to ApplyPredictor
Set up prepare_boundaries as a step prior to ApplyPredictor
Oct 21, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to accommodate the boundary plane implementation and correctly fill physical boundary cells at the right times, this PR sets up a framework to call "fill_boundaries" prior to the ApplyPredictor step, which enables avoiding calling fills at older times (n, n+1/2) once the time step has begun. With all of this new code, this PR is set up to avoid diffs, ensuring the framework does not do something unintentionally. Future PR will introduce diffs by filling BCs at the desired times, instead of conforming to the times the code currently uses.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
The "no diffs" component of development intended by #1210.
The commit to main has the wrong name of the function. Should be "prepare_boundaries" instead of "fill_boundaries"