Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangling reference warning and update amrex #1268

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Fix dangling reference warning and update amrex #1268

merged 10 commits into from
Oct 1, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Sep 30, 2024 •
edited
Loading

Summary

Fix dangling reference warning in the CI.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Closes #1265

@marchdf marchdf marked this pull request as ready for review September 30, 2024 18:42
@marchdf marchdf changed the title Fix dangling reference warning Fix dangling reference warning and update amrex Sep 30, 2024
@marchdf marchdf marked this pull request as draft September 30, 2024 20:32
@marchdf marchdf marked this pull request as ready for review October 1, 2024 22:55
@marchdf marchdf enabled auto-merge (squash) October 1, 2024 22:55
@marchdf marchdf merged commit dbfe6d2 into Exawind:main Oct 1, 2024
15 checks passed
@marchdf marchdf deleted the fix-warn branch October 2, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrood-nrel jrood-nrel jrood-nrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marchdf @jrood-nrel