More multiphase overset improvements #1182
Conversation
This reverts commit 0132b5c.
amr-wind/overset/OversetOps.cpp
Outdated
| GetArrOfConstPtrs(fluxes[lev]), fluxes[lev - 1], | ||
| repo.mesh().refRatio(lev), geom[lev - 1]); | ||
| GetArrOfConstPtrs(fluxes[lev]), fluxes[lev - 1], rr, | ||
| geom[lev - 1]); |
There was a problem hiding this comment.
these changes were necessary to avoid a segfault. I didn't get the segfault previously because I wasn't testing multilevel cases. However, this now conforms to the way it's done in other parts of our code.
There was a problem hiding this comment.
hmmm should it actually be repo.mesh().refRatio(lev-1) ? I am a little weirded out of doing our own math here if we have ref ratio available.
|
The key change is the averaging of the flux to faces. The other things are a tweak to get the right perturbational pressure and removing something not needed for initialization. |
amr-wind/overset/OversetOps.cpp
Outdated
| GetArrOfConstPtrs(fluxes[lev]), fluxes[lev - 1], | ||
| repo.mesh().refRatio(lev), geom[lev - 1]); | ||
| GetArrOfConstPtrs(fluxes[lev]), fluxes[lev - 1], rr, | ||
| geom[lev - 1]); |
There was a problem hiding this comment.
hmmm should it actually be repo.mesh().refRatio(lev-1) ? I am a little weirded out of doing our own math here if we have ref ratio available.
|
All amr-wind tests pass |
|
I decided to also remove two undefined functions from incflo.H |
Summary
Changes necessary for getting the second set of overset regression tests running
Pull request type
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: