Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOB in ActuatorSourceTagging #1173

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix OOB in ActuatorSourceTagging #1173

merged 1 commit into from
Jul 30, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jul 30, 2024 •
edited
Loading

Summary

#1170 introduced an OOB (the passive tracer can have more grow cells than the actuator source). This fixes that.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@marchdf marchdf marked this pull request as ready for review July 30, 2024 20:15
@marchdf marchdf requested a review from mbkuhn July 30, 2024 20:15
@marchdf marchdf enabled auto-merge (squash) July 30, 2024 20:16
@marchdf marchdf merged commit 31ef113 into Exawind:main Jul 30, 2024
14 checks passed
@marchdf marchdf deleted the fix-oob branch July 30, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbkuhn mbkuhn mbkuhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marchdf @mbkuhn