Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only modify velocity of water during ocean wave initialization #1164

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Jul 26, 2024

Summary

Necessary for ABL + waves simulations. To go with other physics classes, the ocean waves need not overwrite the velocities in the air.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Issue Number: maybe #1162

@marchdf
Copy link
Contributor

marchdf commented Jul 26, 2024

This solves #1162 !!

@mbkuhn mbkuhn marked this pull request as ready for review July 26, 2024 20:59
@mbkuhn mbkuhn linked an issue Jul 26, 2024 that may be closed by this pull request
13 tasks
@mbkuhn mbkuhn enabled auto-merge (squash) July 26, 2024 21:13
@mbkuhn mbkuhn merged commit f9f499b into Exawind:main Jul 26, 2024
14 checks passed
@mbkuhn mbkuhn deleted the ow_mistake branch August 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing abl_multiphase_laminar test
2 participants