Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another way to fix the UDF MAC fills #1092

Closed
wants to merge 9 commits into from

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jun 4, 2024

Summary

The dirichlet fill now depends on if we are filling a face-centered or node centered field.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Issue Number: #1076

@marchdf
Copy link
Contributor Author

marchdf commented Jun 4, 2024

Still need to do it for lev != 0

@marchdf
Copy link
Contributor Author

marchdf commented Jun 6, 2024

This PR has made a lot of people very angry and been widely regarded as a bad move.

(the real reason for closing: templating wont work because for lev != 0 we need to pass in an Array of bc functs and so they need to have the same type. It was fun while it lasted. #1093 should be a better fix)

@marchdf marchdf closed this Jun 6, 2024
@marchdf marchdf deleted the fillpatch_sibling_attempt branch June 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants