Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the AMD ABL regtest stable on GPUs #1091

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

moprak-nrel
Copy link
Contributor

Summary

Perturb temperature/velocity values so that the regtest values aren't too small for SGS terms. Currently the alpha_eff is close to machine precision leading to flaky regtest runs on GPUs.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): update regtest parameters

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@moprak-nrel moprak-nrel changed the title Make the ABL regtest stable on GPUs Make the AMD ABL regtest stable on GPUs Jun 4, 2024
@moprak-nrel moprak-nrel requested a review from marchdf June 4, 2024 18:37
@moprak-nrel moprak-nrel marked this pull request as ready for review June 4, 2024 19:17
@moprak-nrel moprak-nrel merged commit 89ee828 into Exawind:main Jun 4, 2024
13 checks passed
@moprak-nrel moprak-nrel deleted the amdfix branch October 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants