Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOF operations changes #1037

Merged
merged 2 commits into from
Jun 5, 2024
Merged

VOF operations changes #1037

merged 2 commits into from
Jun 5, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented May 2, 2024

Summary

  • deprecate vof-only sharpening
  • add replace mask
  • make VOF advection into an operator applied from n to n+1

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Trying to keep the PRs small for incorporating the multiphase hybrid changes into main.

* deprecate vof-only sharpening
* add replace mask
* make VOF advection into an operator applied from n to n+1
@mbkuhn mbkuhn marked this pull request as ready for review May 2, 2024 22:04
@moprak-nrel moprak-nrel requested a review from gdeskos May 7, 2024 20:17
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Jun 5, 2024

@moprak-nrel or @gdeskos, could you give your approval to this? Most of the changes are only to do with multiphase hybrid work, which only affects me. The one aspect of the functionality that still applies during normal standalone operation is that the VOF advection step doesn't work with only the new state of the variable, it starts with the old, applies operations to the nph state as a working copy, then updates the new state. I ran the reg tests and they all passed.

@mbkuhn mbkuhn merged commit eb2df80 into Exawind:main Jun 5, 2024
13 checks passed
@mbkuhn mbkuhn deleted the mphase_hybrid_vofops branch July 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants