Merged
Conversation
| flavor: Utils.specific.removeTimestampableKeysFromConfig(this.flavor.toJSON()), | ||
| application: Utils.specific.removeTimestampableKeysFromConfig(this.prop("application")), | ||
| executable: Utils.specific.removeTimestampableKeysFromConfig(this.prop("executable")), | ||
| flavor: Utils.specific.removeTimestampableKeysFromConfig(this.prop("flavor")), |
Member
There was a problem hiding this comment.
We shouldn't need to change JS code
| "type": self.type, | ||
| } | ||
| if self.type == "execution": | ||
| application = getattr(self, "application", None) or {} |
Member
There was a problem hiding this comment.
Should be in ExecutionUnit
| build: application.build, | ||
| }), | ||
| executable: Utils.specific.removeTimestampableKeysFromConfig({ name: executable.name }), | ||
| flavor: Utils.specific.removeTimestampableKeysFromConfig({ name: flavor.name }), |
| return Utils.hash.calculateHashFromObject(meaningfulFields); | ||
| } | ||
|
|
||
| calculateHash() { |
Member
There was a problem hiding this comment.
| def method_data(self): | ||
| return self.model.method.data | ||
|
|
||
| def calculate_hash(self) -> str: |
Member
There was a problem hiding this comment.
Can override get_hash_object only
|
|
||
| @staticmethod | ||
| def _pick(obj: Dict[str, Any], *keys: str) -> Dict[str, Any]: | ||
| return Unit._compact_dict({k: obj.get(k) for k in keys}) |
Member
There was a problem hiding this comment.
None of the above should be in this class, should be in utils, if needed
| return Unit._compact_dict({k: obj.get(k) for k in keys}) | ||
|
|
||
| @staticmethod | ||
| def _hash_input_content(input_items: Any) -> str: |
| "type": self.type, | ||
| } | ||
|
|
||
| def calculate_hash(self) -> str: |
Member
There was a problem hiding this comment.
This can go to mixin in code
timurbazhirov
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.