SOF-7827: introduce applications schema with build config

[pranabdas]

No description provided.

[timurbazhirov]

Should not be needed

[timurbazhirov]

Information about the "main application" used for categorization purposes

[timurbazhirov]

@k0stik to review the changes in this file

[k0stik]

@pranabdas, why may we not want to use schemas default values?

[pranabdas]

@k0stik while validating and cleaning schemas with validateAndClean, it is injecting default properties such as schemaVersion, which are not present in the original schema. This gives the option to avoid that behavior.

esse/schema/system/schema_version.json

Line 10 in 3fb9fa1

"default": "2022.8.16"

[pranabdas]

Consider this example:

import { validateAndClean } from "@mat3ra/esse/dist/js/utils/ajv";

const schema = {
    "$id": "test-schema",
    "type": "object",
    "properties": {
        "name": {
            "type": "string"
        },
        "default": {
            "type": "string",
            "default": "default"
        },
    }
}

const data1 = {
    "name": "test"
}

const data2 = {
    "name": "test"
}

// default behavior
validateAndClean(data1, schema);
console.log(data1);  // { name: 'test', default: 'default' }

// with useDefaults: false
validateAndClean(data2, schema, { useDefaults: false });
console.log(data2);  // { name: 'test'}

[timurbazhirov]

@k0stik - are we converged here to proceed? If yes, please approve the PR

[k0stik]

Is there a real need for "additionalProperties": true here and in other schemas? This prevents AJV from cleaning redundant data, and in most cases, we can avoid using additionalProperties

[k0stik]

In case we need additionalProperties, it should be placed on the same level as properties and allOf, not inside properties.
Correct:

{
    "allOf": [...],
    "properties": {...},
    "additionalProperties": true
}

Wrong:

{
    "allOf": [...],
    "properties": {
          "additionalProperties": true
     },
}

[pranabdas]

Definitely can remove it here. Actually, I had to remove additionalProperties from schema/software/application.json to be able to clean unwanted keys. But not sure about numerous other places.

[timurbazhirov]

Maybe we can add "additionalProperties" as OK, but filename, basename should not be there

[timurbazhirov]

Since we are defining this item from scratch, I think we should follow the previous convention for camelCase, to stay consistent and avoid any potential issues when generating Py/TS assets.

module_name => moduleName
image_tag => imageTag

It would require a one-time change in the infrastructure configs, but it keeps ESSE clean.