New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added updates and refactored code #89

Open

mscr06 wants to merge 1 commit into EvolveTechnology:master from mscr06:toll-update-java

mscr06 commented Nov 6, 2021

Points Looked at:

Refactor existing code as it has lot of raw data.
Kept main logic code as minimal as possible by extracting enums, constants into new files.
Used enum values as holidays list for a year(2013 doesn't make sense) as it changes every year, better solution would be to read property file outside the codebase.
Kept the code in accordance with sonarqube quality check.
Have written sample main method test file. We can use JUnit if we move to MVC totally.

P.S: GIF is from Hackers movie :)


          Added updates and refactored code

5a4e543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet