Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request from Shihan Silva #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

merinosilva
Copy link

@merinosilva merinosilva commented Mar 17, 2022

Hi,

In this pull request I have included the must-have fixes to the code.
Other than those fixes I would like to do the below changes to the code if it align with the company best practices and guidelines.

  1. Change the project structure and add maven or gradle.
  2. Add JUnit5 to the classpath and create test case in JUnit
  3. Include classes in a package instead of keeping them in the default package
  4. Change the method signature of getTollFee to accept LocalDateTime objects instead of Date objects

Additionally would like to integrate an external API or add a data setup to obtain the holiday list for each year.

Thanks,
Shihan Silva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant