Skip to content

Conversation

microlith57
Copy link
Member

@microlith57 microlith57 commented Sep 15, 2025

important: while testing this, you must apply the following patch to your lönn install:

patch
diff --git a/src/structs/decal.lua b/src/structs/decal.lua
index 48dc27d..ea720c7 100644
--- a/src/structs/decal.lua
+++ b/src/structs/decal.lua
@@ -29,6 +29,7 @@ function decalStruct.decode(data)
     decal._editorLayer = data._editorLayer or 0
 
     decal.depth = data.depth
+    decal.parallax = data.parallax
 
     return decal
 end
@@ -56,6 +57,10 @@ function decalStruct.encode(decal)
         res.depth = decal.depth
     end
 
+    if tonumber(decal.parallax) then
+        res.parallax = decal.parallax
+    end
+
     if tonumber(decal._editorLayer) and decal._editorLayer ~= 0 then
         res._editorLayer = decal._editorLayer
     end

otherwise, you won't be able to place parallax decals!

@maddie480-bot maddie480-bot added the draft This PR is not ready for review yet (bot-managed) label Sep 15, 2025
@microlith57 microlith57 changed the title per decal parallax (wip) per decal parallax Sep 15, 2025
@microlith57 microlith57 marked this pull request as ready for review September 15, 2025 09:27
@microlith57 microlith57 marked this pull request as draft September 15, 2025 09:41
@microlith57
Copy link
Member Author

marked draft for further tiny tweaks

also, specialcase parallax=0.0 to disable parallax
@microlith57 microlith57 marked this pull request as ready for review September 15, 2025 10:09
@@ -1,4 +1,4 @@
using System.Globalization;
using System.Globalization;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? what does github mean by this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTF-8 BOM -> UTF-8

@microlith57 microlith57 added the should be squashed PR with a messy commit history that should be squash merged label Sep 15, 2025
@maddie480-bot maddie480-bot added review needed This PR needs 2 approvals to be merged (bot-managed) and removed draft This PR is not ready for review yet (bot-managed) labels Sep 15, 2025
Copy link
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed This PR needs 2 approvals to be merged (bot-managed) should be squashed PR with a messy commit history that should be squash merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants