Skip to content

Add default values for MapMetaMountain (#935) #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

Add default values for MapMetaMountain (#935) #978

merged 1 commit into from
Sep 8, 2025

Conversation

DashingCat
Copy link
Contributor

This PR adds a default value for the MapMetaMountain data so that we can actually see the Overworld even when no mountain metadata is bundled with a map.

image

Closes #935.

@maddie480-bot maddie480-bot added the review needed This PR needs 2 approvals to be merged (bot-managed) label Sep 3, 2025
microlith57
microlith57 approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@microlith57 microlith57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the end of an era...

Wartori54
Wartori54 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sad) LGTM

Would be nice if there was any insight on how the defaults were chosen, as a comment in ether this PR or in the actual file.

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Sep 7, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed review needed This PR needs 2 approvals to be merged (bot-managed) labels Sep 5, 2025
@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Sep 8, 2025, 8:53 PM UTC, after which the pull request will be able to be merged.

@SnipUndercover
Copy link
Contributor

SnipUndercover commented Sep 6, 2025 •
edited
Loading

Context: a bug has been spotted making the bot roll the "all-clear" confirmation back if the rolling release is less than 3 days, making the "last call window" be shorter in some cases.
The bot was made to re-evaluate all PRs.

@DashingCat
Copy link
Contributor Author

(sad) LGTM

Would be nice if there was any insight on how the defaults were chosen, as a comment in ether this PR or in the actual file.

I tried to find a camera position showing the whole mountain, placed the cursor away from vanilla chapters, and simulated a "zoom in" effect when transitioning from Idle to Select, and from Select to Zoom states.

@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added ready to merge This PR was approved and the last-call window is over (bot-managed) and removed last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Sep 8, 2025
@SnipUndercover
Copy link
Contributor

The end of an era. RIP Vector3.Zero mountain positions.

@SnipUndercover SnipUndercover merged commit bd07735 into EverestAPI:dev Sep 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microlith57 microlith57 microlith57 approved these changes

@Wartori54 Wartori54 Wartori54 approved these changes

Assignees
No one assigned
Labels
ready to merge This PR was approved and the last-call window is over (bot-managed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide better default MountainModel camera position for mod maps
5 participants
@DashingCat @maddie480-bot @SnipUndercover @microlith57 @Wartori54