-
Notifications
You must be signed in to change notification settings - Fork 95
Update CustomMemorialText.cs to position itself sensibly when level.Zoom =\= 1 #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CustomMemorialText.cs to position itself sensibly when level.Zoom =\= 1 #976
Conversation
Fixes unexpected text placement when level.Zoom =\= 1.
Wartori54
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a very reasonable change to me.
If it does cause a significant impact on some maps we will correct be behaviour afterwards, since we do not have any good ways to check this before it gets rolled out. (But, of course, if any reviewer does know of any please do point those out.)
|
I mean, if backwards compat is a concern, there's always the option to create a legacy option defaulting to true on old placements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree with @Wartori54; this fixes a vanilla bug so is in scope for everest
My point is: we should avoid doing that if we can, and not do it potentially needlessly. |
|
The pull request was approved and entered the 3-day last-call window. |
|
The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further. |
|
Context: a bug has been spotted making the bot roll the "all-clear" confirmation back if the rolling release is less than 3 days, making the "last call window" be shorter in some cases. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
|
The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
Like vanilla, the CustomMemorialText assumes that the UI will be at 6x scale from the world.
When Level.Zoom =\= 1, this assumption fails, and the text is placed in a seemingly strange position.
This fix(?) makes the position more in-line with mapper expectations when the zoom factor =\= 1.
I also admit this is partially because people keep bugging me about these being broken with excam. Since I can't patch Everest with a code mod, this is the only way to fix it without duplicating them on my end.