Skip to content

save command #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2025
Merged

save command #975

merged 4 commits into from
Sep 7, 2025

Conversation

microlith57
Copy link
Member

it saves the game

@microlith57
save command
6f003e6 
it saves the game
@microlith57 microlith57 marked this pull request as draft September 1, 2025 09:25
SnipUndercover
SnipUndercover requested changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@SnipUndercover SnipUndercover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this would be better.

(totally wouldn't have missed the NRE if it didn't catch it first)

@microlith57 microlith57 marked this pull request as ready for review September 1, 2025 09:40
@maddie480-bot maddie480-bot added the changes requested This PR cannot be merged because changes were requested (bot-managed) label Sep 1, 2025
SnipUndercover
SnipUndercover approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@SnipUndercover SnipUndercover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it saves the game

@maddie480-bot maddie480-bot added review needed This PR needs 2 approvals to be merged (bot-managed) and removed changes requested This PR cannot be merged because changes were requested (bot-managed) labels Sep 1, 2025
Wartori54
Wartori54 approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really hope it will save the game

@SnipUndercover
Copy link
Contributor

i really hope it will save the game

it saves the game

@microlith57
Copy link
Member Author

it saves the game

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Sep 7, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed review needed This PR needs 2 approvals to be merged (bot-managed) labels Sep 1, 2025
@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Sep 7, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@SnipUndercover
Copy link
Contributor

Context: a bug has been spotted making the bot roll the "all-clear" confirmation back if the rolling release is less than 3 days, making the "last call window" be shorter in some cases.
The bot was made to re-evaluate all PRs.

@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added ready to merge This PR was approved and the last-call window is over (bot-managed) and removed last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Sep 6, 2025
@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Sep 7, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed ready to merge This PR was approved and the last-call window is over (bot-managed) labels Sep 6, 2025
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added ready to merge This PR was approved and the last-call window is over (bot-managed) and removed last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Sep 7, 2025
@SnipUndercover SnipUndercover merged commit 7b26200 into EverestAPI:dev Sep 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnipUndercover SnipUndercover SnipUndercover approved these changes

@Wartori54 Wartori54 Wartori54 approved these changes

Assignees
No one assigned
Labels
ready to merge This PR was approved and the last-call window is over (bot-managed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@microlith57 @SnipUndercover @maddie480-bot @Wartori54