Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend events when saving #301

Closed
wants to merge 7 commits into from

Conversation

Lejdholt
Copy link
Contributor

I want to add metadata that is available in scope, correlationid, causationId , currentuser etc.
This might be away to do it. I'm still thinking on how to do it on the handler side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo

Copy link

github-actions bot commented Nov 30, 2023

Test Results

  51 files  +  34    51 suites  +34   16m 7s ⏱️ + 11m 40s
146 tests +    5  130 ✔️  -     7  0 💤 ±0  16 +12 
426 runs  +285  378 ✔️ +241  0 💤 ±0  48 +44 

For more details on these failures, see this check.

Results for commit 73aa42c. ± Comparison against base commit 0be1656.

This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 })
Eventuous.Tests.AmendStoringEvents ‑ StoreInitial
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 })

♻️ This comment has been updated with latest results.

@Lejdholt Lejdholt closed this Aug 28, 2024
@Lejdholt Lejdholt deleted the amend-event-on-store branch August 28, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant