Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent_jobs usage when reprocessing from the GUI #419

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

JamesWrigley
Copy link
Member

The GUI calls submit_multi() directly so we need to check the database in there instead of reprocess().

@turkot, I'm not sure how this worked for you already if you were reprocessing from the GUI 🤔

The GUI calls `submit_multi()` directly so we need to check the database in
there instead of `reprocess()`.
@JamesWrigley JamesWrigley added the bug Something isn't working label Mar 16, 2025
@JamesWrigley JamesWrigley requested a review from tmichela March 16, 2025 16:09
@JamesWrigley JamesWrigley self-assigned this Mar 16, 2025
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (0298142) to head (f36ce05).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   75.68%   75.68%           
=======================================
  Files          35       35           
  Lines        6144     6144           
=======================================
  Hits         4650     4650           
  Misses       1494     1494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@tmichela tmichela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesWrigley JamesWrigley merged commit 9a65b99 into master Mar 17, 2025
6 checks passed
@JamesWrigley JamesWrigley deleted the concurrent-jobs branch March 17, 2025 08:24
@turkot
Copy link

turkot commented Mar 17, 2025

The GUI calls submit_multi() directly so we need to check the database in there instead of reprocess().

@turkot, I'm not sure how this worked for you already if you were reprocessing from the GUI 🤔

Hi James, I have been reprocessing only with the cli, so it looks like I've avoided the issue so far 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants