Skip to content

Change background color #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025
Merged

Change background color #1432

merged 5 commits into from
Jul 14, 2025

Conversation

clytaemnestra
Copy link
Contributor

In dark mode the dark navbar is not that visible and looks like it's part of the browser. I changed the color to orange, so it's visible in both dark and light modes.

@europython-society
Copy link
Member

europython-society commented Jul 12, 2025

Preview available

Key Value
url https://ep2025-navbar-bg-color.ep-preview.click
last update 2025-07-13T23:00:13.819Z

@hugovk
Copy link
Member

hugovk commented Jul 12, 2025

There's a dark mode?! How do I enable it?

The contrast ratio when hovering the mouse over it is very low, and it's hard to read:

image

Can we change it? Perhaps keep it white, we have the underline to indicate hover.

@nikoshell
Copy link
Contributor

nikoshell commented Jul 12, 2025

There's a dark mode?! How do I enable it?

The contrast ratio when hovering the mouse over it is very low, and it's hard to read:
image

Can we change it? Perhaps keep it white, we have the underline to indicate hover.

Thank you we also notice that.
I was thinking about something from current palette colour
image

@clytaemnestra
Copy link
Contributor Author

@hugovk no dark mode yet, but hopefully for 2026! By dark mode I meant dark mode of the browser:
image


Agreed with @nikoshell to keep the orange, but let's have white as text color and the same white+underline on hover. That way the contrast should be okay.

@nikoshell nikoshell merged commit 18bd1a8 into ep2025 Jul 14, 2025
6 checks passed
@nikoshell nikoshell deleted the ep2025-navbar-bg-color branch July 14, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants