Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-482 Update gradle standard to new. #482

Closed
wants to merge 1 commit into from

Conversation

vLuckyyy
Copy link
Member

No description provided.

@vLuckyyy vLuckyyy changed the title Update gradle standard to new. GH-482 Update gradle standard to new. Aug 24, 2023
@vLuckyyy vLuckyyy added the 💾 code-only This is just a code problem, it doesn't affect the production server label Aug 24, 2023
Copy link
Member

@Rollczi Rollczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jakie feature daje takie zdefiniowane "path", rozumiem, że to scope?

implementation(project(":eternalcore-docs-api"))
implementation(project(mapOf("path" to ":eternalcore-api")))
implementation(project(mapOf("path" to ":eternalcore-paper")))
implementation(project(mapOf("path" to ":eternalcore-docs-api")))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowy standard zmniejsza czytelność. Pytanie czy to nie nadinżynieria? Dasz linka do tego

@Jakubk15
Copy link
Member

Jakie zalety daje ten PR? Zyskamy coś na wydajności? Co w przypadku jeżeli nie przeniesiemy się na nowy standard?

@vLuckyyy vLuckyyy closed this Aug 27, 2023
@vLuckyyy vLuckyyy deleted the update-gradle-standard branch August 29, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 code-only This is just a code problem, it doesn't affect the production server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants