Reworked to function again #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The YoutubeAudioSource.kt file specifically looks for the .tmp file generated first, and then deleted when you don't specify the "-k" option. Adding this allows it to process.
Changed for compatibility issues when compiling Kotlin. The original version pushed no longer works, and the newest version won't process a deprecated function. This version just happens to fit that middle ground necessary to run.
Added specific version notes for JDK and Docker version in case this breaks in the future, you can compare what versions I was using.
Added default localhost and 8080 values to support what Docker will default to.
Added spacing
|
Just so you know, my friend used your fix to get our build working yesterday! So thanks a bunch! |
|
Hi guys, can either of you explain usage for Eternal Jukebox? I can see the track loading to 100% after I pick a song or enter a song URL in the 'Tune' tab, however nothing appears on the screen after the load and the play button does nothing for me. EDIT: Uploading an mp3 file seems to work for me! |
|
@TheDuckMan64 Im assuming the connection to spotify is broken but the actual algo works just fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't able to get the build to function following the instructions included, did some debugging and got it locally working on my end.
If anyone else wants to give this a whirl, feel free. I jammed out for a solid 4-5 hours without issue, 5 songs for an hour and the logs looked okay.
I'll say it again here, I'm not an expert in doing anything like this lol, I just wanted this jukebox back to working again.
This change is