Fix Discord blocking server startup during Cloudflare rate limits - #6618
Open
KeaneAudric777 wants to merge 1 commit into
Open
Fix Discord blocking server startup during Cloudflare rate limits#6618KeaneAudric777 wants to merge 1 commit into
KeaneAudric777 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #6591.
Details
Proposed fix:
Passes
startupAsync()throughess.runTaskAsynchronouslyinEssentialsDiscord.javarather than executing JDA login synchronously on the main thread during plugin enablement.Previously, when JDA encountered connection timeouts or Cloudflare HTTP 429 rate limits, the blocking retry delay stalled the main server thread, hanging startup indefinitely. Offloading the initialization to an asynchronous task allows the server to complete its boot sequence immediately while Discord logs in and handles rate-limit retries in the background. Once JDA connects, interaction registrations are scheduled back onto the main thread via
ess.scheduleSyncDelayedTask().Environments tested:
OS: Windows 11
Java version: Java 21
Demonstration:
[EssentialsDiscord] Attempting to login to Discord...followed by JDA'sEncountered cloudflare rate limit! Retry-After: ...on the main thread, blocking the server from finishing initialization.Done (...)! For help, type "help"), with the rate-limit delay and subsequent Discord login handled gracefully in the background without affecting the tick loop.