Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create Offline Areas from Feature Layer notebook #20

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

justincolville
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

"offline_map = WebMap(offline_map_item)\n",
"\n",
"offline_areas_item = gis.content.get(feature_layer_item_id)\n",
"offline_areas = offline_areas_item.layers[feature_layer_id].query(result_record_count=16, return_all_records=False)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest checking for any existing map areas; currently if any exist will exceed limit of 16. Not sure if requests that exceed that will throw an exception.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are a number of enchantments that we can look at adding post UC

Copy link
Collaborator

@doug-m doug-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted one possible improvement for querying features but otherwise looks good.

@justincolville justincolville merged commit b238a21 into main Jul 10, 2023
1 check passed
@justincolville justincolville deleted the jc/create-offline-fs branch July 10, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants