Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced cartography 1 update #1903

Merged
merged 15 commits into from
Sep 14, 2024
Merged

Advanced cartography 1 update #1903

merged 15 commits into from
Sep 14, 2024

Conversation

nanaeaubry
Copy link
Contributor

No description provided.

@nanaeaubry nanaeaubry added documentation Bugs and enhancement requests for doc (API ref and notebooks) update_24 labels Aug 14, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nparavicini7 nparavicini7 self-requested a review August 22, 2024 23:37
Copy link
Collaborator

@nparavicini7 nparavicini7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guide looks great! Edited a bit of text. Can you remove the smart-mapping guide changes from this one so it doesn't overwrite the other one? I changed that other one a bit too

@nanaeaubry
Copy link
Contributor Author

@nparavicini7 Not sure why smart mapping is showing up... I copied the one that is in next and replaced it with that

Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyaistMap jyaistMap merged commit 62e7949 into next Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Bugs and enhancement requests for doc (API ref and notebooks) update_24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants