DitheringEngine 1.8.2

Merge pull request #11 from Eskils/develop
Eskils · Oct 30, 2024 · f10beb8 · f10beb8
2 parents d97c13c + 3c1fb11
commit f10beb8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -52,7 +52,7 @@ let package = Package(
   dependencies: [
     .package(
       url: "https://github.com/Eskils/DitheringEngine", 
-      .upToNextMinor(from: "1.8.1") // or `.upToNextMajor
+      .upToNextMinor(from: "1.8.2") // or `.upToNextMajor
     )
   ],
   targets: [

diff --git a/Sources/DitheringEngine/Video/VideoAssembler.swift b/Sources/DitheringEngine/Video/VideoAssembler.swift
@@ -40,12 +40,10 @@ class VideoAssembler {
             AVVideoHeightKey: height
         ] as [String : Any]
 
-        let audioSettings = [
-            AVFormatIDKey: kAudioFormatMPEG4AAC,
-            AVSampleRateKey: sampleRate,
-            AVNumberOfChannelsKey: 2,
-            AVEncoderBitRateKey: 160_000
-        ] as [String : Any]
+        let assistant = AVOutputSettingsAssistant(preset: .preset1920x1080)
+        guard let audioSettings = assistant?.audioSettings else {
+            throw VideoAssemblerError.cannotMakeAudioSettingsForPreset
+        }
 
         self.videoInput = AVAssetWriterInput(mediaType: .video, outputSettings: videoSettings)
         if let transform {
@@ -128,6 +126,7 @@ class VideoAssembler {
     enum VideoAssemblerError: Error {
         case cannotAddVideoAssetWriterInput
         case cannotAddAudioAssetWriterInput
+        case cannotMakeAudioSettingsForPreset
     }
 
 }