[fix] Create a shim class providing compat for Pool implementations #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows and MacOS the multiprocess library's Pool class is used, whereas on Linux and other platforms the concurrent.futures library's ProcessPoolExecutor is used. These two classes have similar but not identical APIs. This commit introduces a shim class which adapts the API of multiprocess.Pool to be more similar to ProcessPoolExecutor. This commit will close Ericsson#4338.
frankplow
force-pushed
the
shim-pool-api
branch
from
b447349 to
e3b078f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows and MacOS the multiprocess library's Pool class is used, whereas on Linux and other platforms the concurrent.futures library's ProcessPoolExecutor is used. These two classes have similar but not identical APIs. This commit introduces a shim class which adapts the API of multiprocess.Pool to be more similar to ProcessPoolExecutor.
This commit will close #4338.