Insert call instructions (without any caching) #1276
+605
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure the latter can be removed?
….fill` instead of creating an uninitialized TracedRArray
…urse through the object. This is useful for constructing a new traced object without altering the paths.
…thing. This now handles that.
It checks the contents of the generated MLIR which is different when call operations are generated.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
… call operation for blacklisted operations but not for the functions called within them.
|
Status: |
…en calling `make_tracer` on the `AnyTracedRArray`.
wsmoses
reviewed
May 21, 2025
src/TracedRArray.jl
Outdated
| @@ -675,14 +675,14 @@ function Base.similar( | |||
| ::Broadcasted{AbstractReactantArrayStyle{N}}, ::Type{T}, dims | |||
| ) where {T<:Reactant.ReactantPrimitive,N} | |||
| @assert N isa Int | |||
| return TracedRArray{T,length(dims)}((), nothing, map(length, dims)) | |||
| return Ops.fill(zero(unwrapped_eltype(T)), dims) | |||
There was a problem hiding this comment.
minor, but could we make a smaller PR with some of these utilities to get that in first (and confirm everything works)
Comment on lines
+1150
to
+1152
| args_tuple = push_inst!( | ||
| Expr(:call, GlobalRef(Core, :tuple), fn_args[2:end]...) | ||
| ) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| args_tuple = push_inst!( | |
| Expr(:call, GlobalRef(Core, :tuple), fn_args[2:end]...) | |
| ) | |
| args_tuple = push_inst!(Expr(:call, GlobalRef(Core, :tuple), fn_args[2:end]...)) |
| Expr(:call, GlobalRef(Core, :tuple), fn_args[2:end]...) | ||
| ) | ||
| has_traced_args = push_inst!( | ||
| Expr(:call, GlobalRef(Base, :any), GlobalRef(ReactantCore, :is_traced), args_tuple) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Expr(:call, GlobalRef(Base, :any), GlobalRef(ReactantCore, :is_traced), args_tuple) | |
| Expr( | |
| :call, | |
| GlobalRef(Base, :any), | |
| GlobalRef(ReactantCore, :is_traced), | |
| args_tuple, | |
| ), |
| ), | ||
| ), | ||
| ) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ) | ||
|
|
||
| push_inst!(Expr(:(=), ocres_slot, traced_result)) | ||
| # Jump over the no-trace path |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # Jump over the no-trace path | |
| # Jump over the no-trace path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.