-
Notifications
You must be signed in to change notification settings - Fork 20
Small refactoring of make_mlir_fn
+ more
#1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jumerckx
wants to merge
12
commits into
main
Choose a base branch
from
jm/make_mlir_fn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+214
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if CI failures are related to this pr? |
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr splits the implementation of
make_mlir_fn
into multiple parts:prepare_mlir_fn_args
process_linear_args
finalize_mlir_fn
This is a prerequisite for doing automatic function call insertion as 1., 2., and 4. can be repurposed there. I'd like to merge this already in order to prevent constant merge conflicts as I make progress on the call insertions.
Unrelated, I moved code in
Ops.call
around, and did slight refactoring inutils.jl
by introducingpush_inst!
, both also useful for the call insertion. If any of these changes turn out to be more contentious than the others, I can split this pr as well.