Update GradientUtils.cpp #2234
Open
Update GradientUtils.cpp #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minansys
reviewed
Feb 4, 2025
There was a problem hiding this comment.
@wsmoses With this commit, it resolved the problem. Thanks for the help!
There was a problem hiding this comment.
@wsmoses add } else if (M.getTargetTriple().find("nvptx") != std::string::npos) { to PreserveNVVM.cpp resolve the custom gradient issue for the cuda.
There was a problem hiding this comment.
@minansys can you make a PR with?
There was a problem hiding this comment.
@wsmoses I tried to create a PR, however got the following error:
git push origin --set-upstream mixu/cuda-custom-gradient
remote: Permission to EnzymeAD/Enzyme.git denied to minansys.
fatal: unable to access 'https://github.com/EnzymeAD/Enzyme/': The requested URL returned error: 403
It seems I do not have the write right for the repo. I am using https and PAT instead of ssh. Is there any step to grant my write? Thanks!
There was a problem hiding this comment.
@minansys you can always create a pull request from a fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.