Skip to content

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Sep 30, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Sep 30, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/internal_rules.jl b/src/internal_rules.jl
index eba792b..5b45ac0 100644
--- a/src/internal_rules.jl
+++ b/src/internal_rules.jl
@@ -1380,7 +1380,7 @@ function EnzymeRules.augmented_primal(
     start::Annotation{<:AbstractFloat},
     step::Annotation{<:AbstractFloat},
     stop::Annotation{<:AbstractFloat},
-) where RT <: Union{Active,Const}
+    ) where {RT <: Union{Active, Const}}
 
     if EnzymeRules.needs_primal(config)
         primal = func.val(start.val, step.val, stop.val)
@@ -1395,14 +1395,14 @@ function EnzymeRules.augmented_primal(
 end
 
 function EnzymeRules.reverse(
-    config::EnzymeRules.RevConfig,
-    func::Const{Colon},
-    dret::Const,
-    tape::Nothing,
-    start::Annotation{T1},
-    step::Annotation{T2},
-    stop::Annotation{T3},
-) where {T1<:AbstractFloat,T2<:AbstractFloat,T3<:AbstractFloat}
+        config::EnzymeRules.RevConfig,
+        func::Const{Colon},
+        dret::Const,
+        tape::Nothing,
+        start::Annotation{T1},
+        step::Annotation{T2},
+        stop::Annotation{T3},
+    ) where {T1 <: AbstractFloat, T2 <: AbstractFloat, T3 <: AbstractFloat}
     dstart = if start isa Const
         nothing
     elseif EnzymeRules.width(config) == 1
@@ -1410,7 +1410,7 @@ function EnzymeRules.reverse(
     else
         ntuple(Val(EnzymeRules.width(config))) do i
             Base.@_inline_meta
-	    zero(T1)
+            zero(T1)
         end
     end
 
@@ -1421,7 +1421,7 @@ function EnzymeRules.reverse(
     else
         ntuple(Val(EnzymeRules.width(config))) do i
             Base.@_inline_meta
-	    zero(T2)
+            zero(T2)
         end
     end
 

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.14%. Comparing base (aaa5a36) to head (ee5e287).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/internal_rules.jl 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   75.24%   75.14%   -0.10%     
==========================================
  Files          57       57              
  Lines       17928    17951      +23     
==========================================
  Hits        13490    13490              
- Misses       4438     4461      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Benchmark Results

main ee5e287... main / ee5e287...
basics/make_zero/namedtuple 0.054 ± 0.0019 μs 0.0562 ± 0.0032 μs 0.961 ± 0.065
basics/make_zero/struct 0.257 ± 0.0053 μs 0.271 ± 0.0064 μs 0.949 ± 0.03
basics/overhead 5.55 ± 0.92 ns 4.34 ± 0.01 ns 1.28 ± 0.21
basics/remake_zero!/namedtuple 0.238 ± 0.0053 μs 0.235 ± 0.0068 μs 1.01 ± 0.037
basics/remake_zero!/struct 0.233 ± 0.0052 μs 0.233 ± 0.0047 μs 0.997 ± 0.03
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.23 μs 10.3 ± 0.42 μs 0.996 ± 0.046
fold_broadcast/multidim_sum_bcast/2D 10.3 ± 0.21 μs 10.3 ± 0.21 μs 0.998 ± 0.029
time_to_load 1.29 ± 0.017 s 1.28 ± 0.024 s 1 ± 0.023

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/18146461776/artifacts/4149243019.

@wsmoses wsmoses merged commit 3563bbd into main Oct 1, 2025
43 of 46 checks passed
@wsmoses wsmoses deleted the colr branch October 1, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant