Skip to content

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Sep 22, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/compiler.jl b/src/compiler.jl
index 1afa1a5..c9176a9 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -1020,18 +1020,21 @@ end
     name = T == Float32 ? name * "f" : name
 
     attrs = if LLVM.version().major <= 15
-        LLVM.Attribute[LLVM.EnumAttribute("readnone"), StringAttribute("enzyme_shouldrecompute"),
-                    EnumAttribute("willreturn"),
-                    EnumAttribute("nosync"),
-                    EnumAttribute("nounwind"),
-                    EnumAttribute("nofree"),
-		      ]
+        LLVM.Attribute[
+            LLVM.EnumAttribute("readnone"), StringAttribute("enzyme_shouldrecompute"),
+            EnumAttribute("willreturn"),
+            EnumAttribute("nosync"),
+            EnumAttribute("nounwind"),
+            EnumAttribute("nofree"),
+        ]
     else
-        LLVM.Attribute[EnumAttribute("memory", NoEffects.data), StringAttribute("enzyme_shouldrecompute"),
-                    EnumAttribute("willreturn"),
-                    EnumAttribute("nosync"),
-                    EnumAttribute("nounwind"),
-		    EnumAttribute("nofree")]
+        LLVM.Attribute[
+            EnumAttribute("memory", NoEffects.data), StringAttribute("enzyme_shouldrecompute"),
+            EnumAttribute("willreturn"),
+            EnumAttribute("nosync"),
+            EnumAttribute("nounwind"),
+            EnumAttribute("nofree"),
+        ]
     end
     handleCustom(state, custom, k_name, llvmfn, name, attrs)
     return
diff --git a/src/llvm/attributes.jl b/src/llvm/attributes.jl
index 32480e2..57d5ade 100644
--- a/src/llvm/attributes.jl
+++ b/src/llvm/attributes.jl
@@ -630,10 +630,10 @@ function annotate!(mod::LLVM.Module)
             end
         end
     end
-    
+
     for fname in (
-        "julia.safepoint",
-    )
+            "julia.safepoint",
+        )
         if haskey(funcs, fname)
             for fn in funcs[fname]
                 push!(function_attributes(fn), EnumAttribute("nofree"))

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.47%. Comparing base (de3ebf0) to head (423dfe3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/llvm/attributes.jl 86.66% 8 Missing ⚠️
src/compiler.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
- Coverage   75.23%   72.47%   -2.76%     
==========================================
  Files          56       55       -1     
  Lines       17748    17686      -62     
==========================================
- Hits        13352    12818     -534     
- Misses       4396     4868     +472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Benchmark Results

main 423dfe3... main / 423dfe3...
basics/overhead 5.25 ± 0.011 ns 4.64 ± 0.01 ns 1.13 ± 0.0034
time_to_load 1.3 ± 0.0051 s 1.3 ± 0.0019 s 0.999 ± 0.0042

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17905678091/artifacts/4068755776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants