fix: add a separate check for pad_dot_general #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fix_passes_v2
branch
from
b82de62 to
dd43ec3
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
EnzymeJAX Benchmarks
| Benchmark suite | Current: dd43ec3 | Previous: 9b689ed | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.000004302511992864311 s |
0.000004480150900781155 s |
0.96 |
scatter_sum / JaXPipe / cpu / Primal |
0.0000041834400035440925 s |
0.000004280475992709399 s |
0.98 |
scatter_sum / JaX / tpu / Primal |
0.0001507411580998 s |
0.0001693931275978 s |
0.89 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001594547959975 s |
0.0001651718516135 s |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
wsmoses
reviewed
Oct 4, 2025
|
|
||
| auto lhs = otherIsLHS ? nextOtherArg : pad.getOperand(); | ||
| auto rhs = otherIsLHS ? pad.getOperand() : nextOtherArg; | ||
| if (!areValidDotGeneralInputs(lhs, rhs, op.getDotDimensionNumbersAttr())) |
There was a problem hiding this comment.
this feels like the wrong solution. shouldn't we just slice the inputs properly here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1145