SplitMultiResultScatter #1260
Open
SplitMultiResultScatter #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Aug 6, 2025
| // We expect the return op to return the update arguments. | ||
| size_t numInputs = op.getInputs().size(); | ||
| for (size_t i = 0; i < returnOp.getNumOperands(); ++i) { | ||
| auto returnedVal = dyn_cast<BlockArgument>(returnOp.getOperand(i)); |
There was a problem hiding this comment.
we should generalize this a bit. we want to ideally support cases that aren't just returning a blockargument, but where the result doesn't depend on the other operand. Look at forward/backwards slice for some relevant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1183
Someone that knows the scatter operation better should probably check that my implementation makes sense.