Skip to content

Emit alternatives to pass option [WIP] #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Emit alternatives to pass option [WIP] #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/enzyme_ad/jax/Passes/ConvertParallelToGPU.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ struct SplitParallelOp : public OpRewritePattern<enzymexla::GPUWrapperOp> {
emitAlternative(atoi(blockSizeStr), alternativesOp);
alternativesOp->setAttr("alternatives.descs",
rewriter.getArrayAttr(descs));
} else if (shouldEmitAlternatives(pop)) {
} else if (alternatives && shouldEmitAlternatives(pop)) {
auto alternativesOp = rewriter.create<enzymexla::AlternativesOp>(
loc, ALTERNATIVE_KERNEL_BLOCK_SIZES.size() +
(pop.getUpperBound().size() == 6 &&
Expand Down
3 changes: 2 additions & 1 deletion src/enzyme_ad/jax/Passes/Passes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,8 @@ def ConvertParallelToGPU1 : Pass<"convert-parallel-to-gpu1"> {
let summary = "Convert parallel loops to gpu";
let dependentDialects = ["func::FuncDialect", "LLVM::LLVMDialect", "memref::MemRefDialect", "gpu::GPUDialect", "scf::SCFDialect"];
let options = [
Option<"arch", "arch", "std::string", /*default=*/"\"sm_60\"", "Target GPU architecture">
Option<"arch", "arch", "std::string", /*default=*/"\"sm_60\"", "Target GPU architecture">,
Option<"alternatives", "alternatives", "std::string", /*default=*/"false", "Enable block alternatives">,
];
}

Expand Down
Loading