Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing hail axiom and depth of water ice axiom #1492

Closed
wants to merge 1 commit into from
Closed

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented Feb 9, 2024

May fix EBISPOT/ols4#619

See #1491

@rduerr
Copy link
Contributor

rduerr commented Feb 10, 2024

So I get the change you made to hail; but the change to 'depth of water ice' was handled differently due to the factor that it is a quality. I presume 'Equivalent To' should be the pattern for qualities?

I appreciate the explanations and if you'd like a "formal review" I suppose I could (after you add the explanation for the change for the 'depth of water ice'. Just trying to learn and have a little bit of a proprietary interest in the cryo terms....

@cmungall
Copy link
Member Author

cmungall commented Feb 12, 2024 via email

@cmungall
Copy link
Member Author

cmungall commented Mar 6, 2024

This commit accidentally included minor changes to the derived envo.owl file

Replaced by #1498

@cmungall cmungall closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hail shows up as a root term in ENVO
2 participants