Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the id we use for Bio::Seq #706

Open
wants to merge 1 commit into
base: release/111
Choose a base branch
from
Open

Fix the id we use for Bio::Seq #706

wants to merge 1 commit into from

Conversation

EbiArnie
Copy link
Contributor

  • We use an id to construct a Bio::Seq object. Before, we would pass in an actual object reference instead of a string. This could result in a segfault later. This occurs because BioPerl will clone the object. The Transcript object contains DBI handles, these will frequently result in segfaults when cloned. Force a string instead.

@EbiArnie
Fix the id we use for Bio::Seq
4a1aad3 
- We use an id to construct a Bio::Seq object. Before, we would pass in
  an actual object reference instead of a string. This could result in a
  segfault later. This occurs because BioPerl will clone the object. The
  Transcript object contains DBI handles, these will frequently result
  in segfaults when cloned.
  Force a string instead.
sgiorgetti
sgiorgetti approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@sgiorgetti sgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

sgiorgetti
sgiorgetti requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@sgiorgetti sgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because of two reasons

  • missing copyright update
  • test suite considering Ensembl schema version-1 as benchmark for the changes, instead of going through the patches.

The second one can be forgiven, as we know these changes are irrelevant fir that.
The first failure must be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiorgetti sgiorgetti sgiorgetti requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EbiArnie @sgiorgetti