Skip to content

Match highlighted orthologue by gene and species #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Jun 23, 2025

Description

In conjunction with eg-web-common PR 143 and eg-web-metazoa PR 46, this PR would:

  • pass an s1 parameter with the gene-tree links in an orthologue table, whose value is the URL of the species containing the given orthologue;
  • add an s1 parameter to gene-tree views, which is expected to contain the species URL of the genome containing the gene specified by g1;
  • use the species indicated by s1 to help unambiguously identify the gene specified by g1 for highlighting in a given gene-tree view; and
  • repurpose the '_leaves' item of node features in the genetree GlyphSet to identify leaves by their concatenated genome_db_id and gene stable ID, making it possible for a highlighted orthologue to be identified even if in a collapsed branch of the gene tree.

Views affected

This is expected to affect gene-tree views in which an orthologue is highlighted, such as those linked from the ComparaOrthologs view.

Some example links have been added to the related JIRA issue.

Possible complications

Complications are not expected, as the s1 parameter has not (as far as I know) been used in a ComparaTree component, and the '_leaves' item of node features should be safe to repurpose as they are not (as far as I know) currently used.

Merge conflicts

None detected.

Related JIRA Issues (EBI developers only)

  • ENSCOMPARASW-8505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant