Add notifications support to CommunicationPanel #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imransl
approved these changes
Sep 3, 2024
|
NOTE: this shouldn't be merged and released until roughly beta3. |
|
I believe that the behaviour is as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up until now, the CommunicationPanel (the panel that slides from the right upon click on the conversation icon) only showed the "Contact Us" form. This PR adds the capability to show notifications ("Messages").
The proper, long-term architecture for notifications is unclear. For now, the requirement is only to show one notification ("welcome to beta, etc."), which automatically opens the communication panel if the user hasn't seen it. If the user simply closes the panel or clicks on the "use beta" button, the notification remains accessible (shows up as a green dot next to the conversation icon). If the user chooses to "clear the message", it disappears completely.
notifications.mp4
I wonder if the
is_important: truefield should instead be something likebehavior: "noisy".Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2690
Deployment URL(s)
http://announce-rapid.review.ensembl.org