Skip to content

hotfix/fix-ci-errors #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

hotfix/fix-ci-errors #19

wants to merge 9 commits into from

Conversation

@jschoewe
Copy link

@jschoewe jschoewe commented Feb 14, 2025 •
edited
Loading

  • Bumped pyVmomi to latest version to fix cyclic dependency in setup.py
  • Removed unnecessary test requirements
  • assertEquals has been deprecated since python 2.7 and replaced with assertEqual
    https://pydoc-zh.readthedocs.io/en/latest/library/unittest.html#deprecated-aliases
  • Returning anything other than None in test_ functions is deprecated
  • Removed test_config_schema.py because the self.shell.run() function was causing issues and the whole file is unnecessary anyway because several different configs are already tested in the test_action_vmwarelib_actions.py file

@jschoewe jschoewe requested a review from bishopbm1 February 14, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bishopbm1 bishopbm1 Awaiting requested review from bishopbm1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jschoewe @bishopbm1