-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Use -SNAPSHOT Reaper and Distribution #387
Conversation
🛰️ Build DistributionBuild available for installation
🛸 Powered by Emerge Tools |
android/settings.gradle.kts
Outdated
@@ -28,6 +28,10 @@ dependencyResolutionManagement { | |||
repositories { | |||
google() | |||
mavenCentral() | |||
|
|||
// Snapshots: | |||
maven("https://oss.sonatype.org/content/repositories/snapshots") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use repository content filtering for snapshots, otherwise it can slow down dependency resolution as we need to check every dependency against every repo if not found.
I also think we should just use the s01 address and not both for the same performance reason.
content {
includeGroup(“com.emergetools")
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and I just learned that you can declare this as a snapshots only repository like so: https://docs.gradle.org/current/userguide/filtering_repository_content.html#maven_repository_filtering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated
6956494
to
edc0fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.