Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Use -SNAPSHOT Reaper and Distribution #387

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

chromy
Copy link
Contributor

@chromy chromy commented Mar 3, 2025

No description provided.

Copy link

emerge-tools bot commented Mar 3, 2025

🛰️ Build Distribution

Build available for installation

App Name App ID Platform Version Tag Install Page
Hacker News com.emergetools.hackernews android 1.0.2 release 🔗 Install Build

🛸 Powered by Emerge Tools

@@ -28,6 +28,10 @@ dependencyResolutionManagement {
repositories {
google()
mavenCentral()

// Snapshots:
maven("https://oss.sonatype.org/content/repositories/snapshots")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use repository content filtering for snapshots, otherwise it can slow down dependency resolution as we need to check every dependency against every repo if not found.
I also think we should just use the s01 address and not both for the same performance reason.

content {
  includeGroup(“com.emergetools")
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and I just learned that you can declare this as a snapshots only repository like so: https://docs.gradle.org/current/userguide/filtering_repository_content.html#maven_repository_filtering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated

@chromy chromy force-pushed the chromy/2025-03-03-use-snapshot branch from 6956494 to edc0fb0 Compare March 4, 2025 18:15
Copy link
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chromy chromy merged commit 047bd9c into main Mar 5, 2025
5 checks passed
@chromy chromy deleted the chromy/2025-03-03-use-snapshot branch March 5, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants