Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETDistribution for iOS #348

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Add ETDistribution for iOS #348

merged 7 commits into from
Feb 4, 2025

Conversation

Itaybre
Copy link
Collaborator

@Itaybre Itaybre commented Jan 31, 2025

No description provided.

Copy link

emerge-tools bot commented Jan 31, 2025

📸 Snapshot Test

88 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
HackerNews
com.emergetools.hackernews
0 0 0 0 0 0 N/A
HackerNews
com.emergetools.hackernews.snapshots
0 0 0 0 70 0 N/A
HackerNews Swift-Snapshot-Testing
com.emerge.hn.Hacker-News.swiftsnapshottesting
0 0 0 0 18 0 N/A
HackerNews
com.emergetools.hackernews.adhoc
0 0 0 0 0 0 N/A

🛸 Powered by Emerge Tools

import ETDistribution

struct AutoUpdateManager {
@MainActor static func checkForUpdates() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use async/await with a checked continuation? Would love to use async everywhere possible. 😈

Copy link

emerge-tools bot commented Feb 4, 2025

2 builds increased size, 1 build had no size change

Name Version Download Change Install Change Approval
HackerNews
com.emergetools.hackernews.snapshots
3.6 (1) 4.5 MB ⬆️ 366 B 10.9 MB ⬆️ 4.7 kB (0.04%) N/A
⚠️ HackerNews
com.emergetools.hackernews.adhoc
3.6 (1) 3.7 MB ⬆️ 81.2 kB (2.22%) 6.5 MB ⬆️ 280.8 kB (4.65%) N/A
HackerNews
com.emergetools.hackernews
3.6 (1) 3.6 MB ⬇️ 18 B 6.1 MB - N/A

HackerNews 3.6 (1)
com.emergetools.hackernews.snapshots

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 4.7 kB (0.04%)
Total download size change: ⬆️ 366 B

Largest size changes

Item Install Size Change
🗑 HackerNews.$s10HackerNews0025SettingsScreenswift_jqFBgfMX203_0_33... ⬇️ -1.5 kB
DYLD.String Table ⬆️ 1.1 kB
📝 HackerNews.$s10HackerNews0025SettingsScreenswift_jqFBgfMX223_0_33... ⬆️ 908 B
Other ⬆️ 4.2 kB
View Treemap

Image of diff

HackerNews 3.6 (1)
com.emergetools.hackernews.adhoc

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 280.8 kB (4.65%)
Total download size change: ⬆️ 81.2 kB (2.22%)

Largest size changes

Item Install Size Change
📝 Code Signature ⬆️ 24.4 kB
📝 DYLD.String Table ⬆️ 23.0 kB
📝 DYLD.Lazy Bind ⬆️ 10.3 kB
📝 DYLD.Bind ⬆️ 5.1 kB
📝 CodeResources ⬆️ 4.1 kB
View Treemap

Image of diff

HackerNews 3.6 (1)
com.emergetools.hackernews

No changes to report


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@Itaybre Itaybre force-pushed the feature/etdistribution branch from 195b18d to 2a1357a Compare February 4, 2025 19:42
@Itaybre Itaybre merged commit fb80e92 into main Feb 4, 2025
6 checks passed
@Itaybre Itaybre deleted the feature/etdistribution branch February 4, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants