Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub to build & publish APK to GitHub Releases #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bartekpacia
Copy link

resolve #140

@rbro112
Copy link
Contributor

rbro112 commented Sep 18, 2024

Thanks for the submission @bartekpacia!

We actually already have a release workflow that builds the signed release AAB and pushes to an internal S3 bucket we use to store builds before we manually release on Play: https://github.com/EmergeTools/hackernews/blob/main/.github/workflows/android_release_build.yml.

My recommendation here would be to add your APK build job to this workflow to have them combined. This workflow does run after a release is made (the published event), so we might need to have a new job created to build the debug APK on the created release event, which might warrant a separate workflow, but not 100% sure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish fat APK in GitHub releases?
2 participants