fix(expr): ignore untyped NULL metadata in VALUES - #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NULLexpressions fromVALUESfield-metadata reconciliationNULLappears first or lastWhy
Untyped
NULLhas no concrete Arrow type or field metadata. Comparing its empty metadata with metadata-bearing expressions incorrectly rejects otherwise validVALUEScolumns. This surfaced in Rustice when ARRAY wire-type metadata was preserved for non-NULL array expressions.The change is planning-only and removes metadata work for
NULLexpressions; it adds no per-row execution cost.Validation
cargo +1.95.0 test -p datafusion-expr(252 unit tests; 55 doctests passed, 3 ignored)cargo +1.95.0 clippy -p datafusion-expr --all-targets -- -D warningscargo +1.95.0 fmt --all -- --check