Add the ability to override an invoice amount to the htlc_accepted hook #8671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nepet
force-pushed
the
2544-add-total_amt_msat-to-htlc_accepted_hook
branch
2 times, most recently
from
17695a5 to
bd26406
Compare
Adds `expected_msat_override` to the `invoice_check_payment` check. If it's set, it will be used to override the invoice amount as the expected amount of the payment check. This enables us to charge a different amount for a payment than the amount stated on the invoice. Signed-off-by: Peter Neuroth <[email protected]>
This commit introduces a new field `invoice_msat` to the htlc_accepted hook. If this field is specified it will replace the amount of the invoice that belongs to the payment_hash of the HTLC on internal checks. This is useful in scenarios where we actually expect a smaller amount than initially specified in an invoice. Changelog-Changed: Plugins: `htlc_accepted` hook can now override the expected total amount of the invoice that belongs to the HTLC. Signed-off-by: Peter Neuroth <[email protected]>
nepet
force-pushed
the
2544-add-total_amt_msat-to-htlc_accepted_hook
branch
from
bd26406 to
5c0bb5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
25.12 FREEZE October 27th: Non-bugfix PRs not ready by this date will wait for 26.03.
RC1 is scheduled on November 10th
The final release is scheduled for December 1st.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
Allow plugins to override the effective invoice amount during payment checks from the
htlc_acceptedhook. This enables use-cases where the actually expected (or allowed) amount differs from the amount encoded in the original invoice.This is especially useful for LSP clients on Greenlight. An LSP client expects an amount that is reduced by the opening fee that the LSP deducts from the HTLC set belonging to a certain invoice. Typically that would necessitate signing two different invoices with the same payment hash: one with the expected amount and another with the opening fee added to the amount. Using this hook instead saves Greenlight nodes some round trips to the signer.
amount_received_msatfield inlistinvoicescalls.