Skip to content

cln-bip353: add plugin that fetches payment instructions from human readable addresses #8362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+425 −16
Draft

cln-bip353: add plugin that fetches payment instructions from human readable addresses #8362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ compile_commands.json
target
plugins/cln-grpc
plugins/clnrest
plugins/cln-bip353

# Build directories
bionic/
Expand Down
218 changes: 207 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ members = [
"plugins/grpc-plugin",
"plugins/rest-plugin",
"plugins/lsps-plugin",
"plugins/bip353-plugin",
]
2 changes: 1 addition & 1 deletion contrib/pyln-testing/pyln/testing/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ def __init__(self, node_id, lightning_dir, bitcoind, executor, valgrind, may_fai
if dsn is not None:
self.daemon.opts['wallet'] = dsn
if valgrind:
trace_skip_pattern = '*python*,*bitcoin-cli*,*elements-cli*,*cln-grpc*,*clnrest*'
trace_skip_pattern = '*python*,*bitcoin-cli*,*elements-cli*,*cln-grpc*,*clnrest*,*cln-bip353*'
if not valgrind_plugins:
trace_skip_pattern += ',*plugins*'
self.daemon.cmd_prefix = [
Expand Down
4 changes: 2 additions & 2 deletions doc/getting-started/getting-started/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pip3 install pytest

If you can't install `lowdown`, a version will be built in-tree.

If you want to build the Rust plugins (currently cln-grpc and clnrest, which changed from Python to Rust as of v25.02):
If you want to build the Rust plugins (currently cln-grpc, cln-bip353 and clnrest, which changed from Python to Rust as of v25.02):

```shell
sudo apt-get install -y cargo rustfmt protobuf-compiler
Expand All @@ -141,7 +141,7 @@ sudo RUST_PROFILE=release make install

> 📘
>
> If you want disable Rust because you do not want use it or you do not want `cln-grpc` or `clnrest`, you can use `./configure --disable-rust`.
> If you want disable Rust because you do not want use it or you do not want `cln-grpc`, `cln-bip353` or `clnrest`, you can use `./configure --disable-rust`.

To build CLN for development:

Expand Down
Loading
Loading