fuzz-tests: improve fuzz-bech32
#8311
Open
+23
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2025 05:25
Changelog-None: Use the common library utilities for temporary allocations instead of manually calling `malloc` and `free`. This makes the code conformant with rest of the codebase and reduces the chances of leaks.
According to `common/bech32.h`, the valid values of witness program version are between 0 and 16 (inclusive). Update the test to iterate over all of these values.
morehouse
reviewed
Jun 7, 2025
tests/fuzz/fuzz-bech32.c
Outdated
| uint8_t *converted = tal_arr(tmpctx, uint8_t, size * 2); | ||
| size_t converted_len = 0; | ||
| if (bech32_convert_bits(converted, &converted_len, 5, data, size, 8, 1)) { | ||
| uint8_t *deconverted = tal_arr(tmpctx, uint8_t, converted_len * 2); |
There was a problem hiding this comment.
Does deconverted need to be size converted_len * 2? If we're going from 5 bits back to 8 bits, shouldn't we need at most size bytes?
tests/fuzz/fuzz-bech32.c
Outdated
| @@ -60,5 +60,18 @@ void run(const uint8_t *data, size_t size) | |||
| assert(memcmp(data_out, data, data_out_len) == 0); | |||
| } | |||
|
|
|||
| /* Test 8-to-5 bit roundtrip conversion */ | |||
There was a problem hiding this comment.
Would it make sense to do the roundtrip as part of the above call to bech32_convert_bits?
There was a problem hiding this comment.
Makes sense, the calls above don't test a whole lot.
Currently, the test only verifies the 5-to-8 bit conversion. Replace it with a roundtrip check that verifies 8-to-5 bit conversion as well.
Change in the fuzzing scheme of fuzz-bech32 led to the discovery of test inputs that result in greater in code coverage. Add these inputs to the test's seed corpus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add improvements to
tests/fuzz/fuzz-bech32and add the coverage increasing inputs to the corresponding corpus.Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse