Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Section on Sign Order to About #482

Merged
merged 1 commit into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/about/ui/about.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function getTabs({
{AboutCorpus(markupService)}
</Tab>,
<Tab key="signs" eventKey="signs" title="Signs">
{AboutSigns()}
{AboutSigns(markupService)}
</Tab>,
<Tab key="dictionary" eventKey="dictionary" title="Dictionary">
{AboutDictionary(markupService)}
Expand Down
23 changes: 22 additions & 1 deletion src/about/ui/signs.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
import React from 'react'
import ExternalLink from 'common/ExternalLink'

import { Markdown, MarkdownParagraph } from 'common/Markdown'
import Markup from 'markup/ui/markup'
import MarkupService from 'markup/application/MarkupService'

import fossey from 'about/ui/static/fossey.jpg'
import meszl from 'about/ui/static/meszl.jpg'

export default function AboutSigns(): JSX.Element {
export default function AboutSigns(markupService: MarkupService): JSX.Element {
return (
<>
<MarkdownParagraph
Expand Down Expand Up @@ -131,6 +135,23 @@ export default function AboutSigns(): JSX.Element {
Furthermore, a system for automatically labeling photographs has been
implemented and is undergoing refinement.
</p>
<h3>V. Sign Order</h3>
<Markup
markupService={markupService}
text="The direct order of Neo-Assyrian signs is taken from @bib{RN680};
that of Neo-Babylonian signs follows @bib{RN680@693–706}. The reverse order
of Neo-Assyrian follows the order of @bib{kataja1988reverse}. The reverse
order of the Neo-Babylonian signs has been established by E. Jiménez and
S. Cohen using the list of Neo-Babylonian forms in @bib{RN680@693–706}; a
complete list of Neo-Babylonian signs in reverse order can be downloaded
here."
/>
<ExternalLink
href="https://doi.org/10.5281/zenodo.11645437"
title="Reverse Neo-Babylonian Sign List"
>
here
</ExternalLink>
</>
)
}
Loading