-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust bibliography search #374
Conversation
|
||
get abberviationContainer(): string | undefined { | ||
const containerTitleShort = this.shortContainerTitle | ||
const collectionNumber = this.collectionNumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
get volume(): string { | ||
return _.get(this.cslData, 'volume', '') | ||
} | ||
|
||
get link(): string { | ||
const url = _.get(this.cslData, 'URL', '') | ||
const doi = _.get(this.cslData, 'DOI', '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
return containerTitleShort | ||
? `${containerTitleShort}${collectionNumber}` | ||
: undefined | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function abbreviations
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Code Climate has analyzed commit 7fb1a91 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 83.3% (75% is the threshold). This pull request will bring the total coverage in the repository to 90.7% (0.0% change). View more on Code Climate. |
No description provided.