Feature-authorized-scopes-updater #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: ebl/fragmentarium/web/bootstrap.py
📄 File: ebl/fragmentarium/web/fragments.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
| resp.status = falcon.HTTP_200 | ||
| resp.media = create_response_dto(updated_fragment, user, has_photo) | ||
| except ValueError as error: | ||
| raise DataError(error) |
There was a problem hiding this comment.
suggestion (code-quality): Explicitly raise from a previous error (raise-from-previous-error)
Suggested change
| raise DataError(error) | |
| raise DataError(error) from error |
* adapt on_get to return provenance parents in square brackets * reformatting * Fixed test for provenance
* Remove user scopes from latest addition aggregation Only include "open for all" fragments * add test_query_latest_skips_restricted_fragments
* update ScopeField * update function call * update test data * update match_user_scopes
* install ruff * reformat files * fix mocking calls to user profile * suppress "Unable to concatenate tuple [60]" error * fix formatting error * refactor * update tasks * use ruff for linting and formatting * remove old config file * bugfix * add ruff * replace tuple() with () * remove C408 from ignored rules * replace `tuple()` with literal `()` and reformat
…m/ElectronicBabylonianLiterature/ebl-api into feature-authorized-scopes-updater
…m/ElectronicBabylonianLiterature/ebl-api into feature-authorized-scopes-updater
|
Code Climate has analyzed commit 9b4c99b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.3% (75% is the threshold). This pull request will bring the total coverage in the repository to 91.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added updater of authorized_scopes field in Fragment based on Genre updater